Skip to content

[DONT MERGE] crater run for FCW on #[should_panic] #150727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Bryntet wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[DONT MERGE] crater run for FCW on #[should_panic] #150727

Bryntet wants to merge 4 commits into from

Conversation

@Bryntet
Copy link
Contributor

@Bryntet Bryntet commented Jan 6, 2026

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jan 6, 2026

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 6, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 6, 2026

r? @WaffleLapkin

rustbot has assigned @WaffleLapkin.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Bryntet
Copy link
Contributor Author

Bryntet commented Jan 6, 2026

r? @JonathanBrouwer

@Bryntet Bryntet marked this pull request as draft January 6, 2026 17:08
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2026
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 6, 2026

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Jan 6, 2026
@rust-bors
Auto merge of #150727 - Bryntet:test_err_should_panic, r=<try>
c374c9f 
[DONT MERGE] crater run for FCW on `#[should_panic]`
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 6, 2026

@bors try cancel

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 6, 2026

Try build cancelled. Cancelled workflows:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Bryntet Bryntet force-pushed the test_err_should_panic branch from 1dc6991 to b96b9f2 Compare January 8, 2026 13:32
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 8, 2026

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Jan 8, 2026
@rust-bors
Auto merge of #150727 - Bryntet:test_err_should_panic, r=<try>
66388cc 
[DONT MERGE] crater run for FCW on `#[should_panic]`
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 8, 2026

☀️ Try build successful (CI)
Build commit: 66388cc (66388cc165a6c4ac98c074dc9f0281ff23528c55, parent: bca37a20bd376ce3fd138e7cdee7fe704e0f8814)

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 8, 2026

@craterbot check

@craterbot
Copy link
Collaborator

craterbot commented Jan 8, 2026

👌 Experiment pr-150727 created and queued.
🤖 Automatically detected try build 66388cc
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 8, 2026
@craterbot
Copy link
Collaborator

craterbot commented Jan 8, 2026

🚧 Experiment pr-150727 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Jan 10, 2026

🎉 Experiment pr-150727 is completed!
📊 1502 regressed and 3 fixed (778934 total)
📊 1969 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-150727/retry-regressed-list.txt ↩

@craterbot craterbot removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jan 10, 2026
@craterbot craterbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 10, 2026
Open
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 11, 2026

☔ The latest upstream changes (presumably #150957) made this pull request unmergeable. Please resolve the merge conflicts.

@Bryntet Bryntet force-pushed the test_err_should_panic branch from b96b9f2 to 9a50d00 Compare January 18, 2026 17:45
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 18, 2026

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Jan 18, 2026
@bors
Auto merge of #150727 - Bryntet:test_err_should_panic, r=<try>
f93f9bd 
[DONT MERGE] crater run for FCW on `#[should_panic]`
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 18, 2026

☀️ Try build successful (CI)
Build commit: f93f9bd (f93f9bd1edfdb032bbf1c02773329541b22aa5a7, parent: 2b112efcccf831c0e0fbaa6470047c7067f12801)

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 18, 2026

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-150727/retry-regressed-list.txt p=1

p=1 because this is a retry of a small regressed list, so should be done fast

@craterbot
Copy link
Collaborator

craterbot commented Jan 18, 2026

👌 Experiment pr-150727-1 created and queued.
🤖 Automatically detected try build f93f9bd
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 18, 2026

☔ The latest upstream changes (presumably #151325) made this pull request unmergeable. Please resolve the merge conflicts.

@craterbot
Copy link
Collaborator

craterbot commented Jan 19, 2026

🚧 Experiment pr-150727-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Jan 19, 2026

🎉 Experiment pr-150727-1 is completed!
📊 204 regressed and 0 fixed (3455 total)
📊 198 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-150727-1/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Bryntet @rustbot @JonathanBrouwer @rust-log-analyzer @craterbot @WaffleLapkin